mark padgham
mark padgham
@b-rodrigues Sorry for slight delay here, we're still trying to find and assign an editor to handle this. Should be assigned soon.
@antaldaniel Thank you again for all of the work you have put into updating the package. You are I have [discussed elsewhere](https://github.com/ropensci/dev_guide/issues/868#issuecomment-2668532472) that we at rOpenSci do indeed firmly request...
good point @agila5. The original idea with that was that the igraph version would only inherit the columns returned by the (internal) function `dodgr:::dodgr_graph_cols()`. All the actual machinery of `dodgr`...
Hi @kelliejarcher, I'm jumping in briefly while current Editor-in-Chief @adamhsparks is away on a short break. Your package definitely seems like a good fit. As a stats submission, assessing fit...
That's a really good point @agila5, and one I'll definitely update docs somewhere to address. The code should probably be improved there as well, because it currently assumes tagging strictly...
@agila5 Could you please have a look over PR #251 and let me know what you think? Or suggest any edits or improvements you can think of? Thanks!
Re-opening to address [this reprex](https://github.com/UrbanAnalyst/dodgr/pull/251#discussion_r1780888961) of @agila5: ``` r library(dodgr) library(sf) #> Linking to GEOS 3.11.2, GDAL 3.7.2, PROJ 9.3.0; sf_use_s2() is TRUE # The default mode of transport is...
But carefully. I discovered this trying to debug another pkg. With no STD, most systems seem to currently default to 17, and that has some breaking changes in precompiled `bits/std`...
This uses [Davis Vaughan's implementation of tree-sitter in r](https://github.com/DavisVaughan/r-tree-sitter), based on tree-walking code I've already implemented [in `pkgsimil`](https://github.com/ropensci-review-tools/pkgsimil/blob/main/src/tree-parser.c). Davis's version exposes the tree cursor directly in R, and does not...
Here's an improved version of the function, minus the debugging lines: ``` r walk_one_tree