mark padgham
mark padgham
> When I added this badge and updated github, the pgkcheck failed but it seems to be due to an R package that I am not explicitly using, as the...
@tdhock Any progress on finding another reviewer here?
Sorry @jmaspons, but another request for change: All of the `opq("place name")` calls need to be in `\dontrun`, because they call the nominatim API to get the bounding box. The...
> Ready for a new round, @mpadge Thanks so much for all your work. The only minor suggestions I've now added are removing all of the `# bounding box of...
> > I was just referring to the fact that in our case we have to have examples witth `\dontrun`. > > But why? It's because it would take too...
No, `valgrint-test.R` is [still there](https://github.com/ropensci/osmdata/tree/main/tests). If you click on a "test-coverage" run, then open the "Test Coverage" step, at the top somewhere you should see this: ``` Running specific tests...
Oh yeah, you're right! The function is just a definition. The script was the bit that actually ran it. I'll try to get it going again. Thanks! (And twalt ervor...
Fixed by #82, which added https://github.com/ropensci-review-tools/pkgstats/blob/main/R/roxygen-blocks.R. This only gets docline stats for non-exported functions from `roxygen2`, and so still won't count other ways to document internal functions other than that....
Good plan. It wasn't auto-generated, but used [the code here](https://github.com/ropensci/dev_guide/issues/657#issuecomment-2713796828) to auto-identify, and there were only two missing anchors, so easy to re-generate