RcppParallel icon indicating copy to clipboard operation
RcppParallel copied to clipboard

Remove PKG_CXXFLAGS = CXX11STD from Makevars

Open mpadge opened this issue 2 years ago • 3 comments

CRAN will now insist on that being removed anyway, as confirmed yesterday in email from UL which explained that their check is now just grep -r CXX11, so this package will fail in current form.

mpadge avatar Jun 02 '23 08:06 mpadge

Okay, I'll wait until we receive that communication from CRAN then?

kevinushey avatar Jun 02 '23 16:06 kevinushey

FWIW I sort-of did it "rolling" in all my repos. It is a bit of a mixed bag: I have a few where I have set C++14 (because of Boost libraries or alike) which leads to a nag, as does setting C++17. But they clearly no longer want us to set C++11 unless required so just removing worked for me. So my $0.02 would be to remove prior to next upload.

eddelbuettel avatar Jun 02 '23 16:06 eddelbuettel

But carefully. I discovered this trying to debug another pkg. With no STD, most systems seem to currently default to 17, and that has some breaking changes in precompiled bits/std headers.

mpadge avatar Jun 03 '23 08:06 mpadge