mark padgham

Results 619 comments of mark padgham

Thanks @MargaretSiple-NOAA for really useful feedback! The issue linked above has details of changes made in response. I'd say the most important of those for reviewers of this package is...

Thanks @MargaretSiple-NOAA, I've fixed the issue linked above, so `devtools::test()` should now work for everybody.

Thank you very much @Selbosh for your review. You've really immediately picked up the big weakness of package design thus far: It was pulled together for a very specific use...

Error is due to `_pkgdown.yml`, but there's nothing wrong with that, as far as I can tell. Strange ...

:question: ``` Warning messages: 1: In readLines(file, warn = readLines.warn) : incomplete final line found on '_pkgdown.yml' 2: In readLines(file, warn = readLines.warn) : incomplete final line found on '/tmp/RtmpTvtrZh/mapscanner-source/_pkgdown.yml'...

@maelle There does indeed seem to be an error, from `knitr::include_graphics()`, which generates: ``` Error: [ENOENT] Failed to realize '/tmp/RtmplQApHk/omama-polygons.png': no such file or directory ``` But the file does...

[Still errors](https://github.com/r-universe/ropensci/actions/runs/13196811787/job/36839842341) ... :confused: ❓

Aha, but now at least i can reproduce locally, so should be able to fix 🔧 🚄

![Image](https://github.com/user-attachments/assets/40e9443e-a7d6-4cb5-8190-c9b12de1cdbd) Finally 🥳

@n-kall Thanks for this exciting submission. We're hoping to find a stats editor to handle it in the coming days. You'll see progress as soon as that has happened.