mark padgham

Results 617 comments of mark padgham

sorry @tdhock, another bot glitch there - bot commands have to be kept as just that, with no additional comments. And yes, the point of the above-linked issue is to...

One minor update on @jooolia's comment: the rOpenSci DevGuide [recommends using `@noRd` instead of `@Keywords internal`](https://devguide.ropensci.org/building.html#roxygen2-use).

@jooolia Our automated system only checks for continuous integration on GitHub. This package uses travis for CI, so that failing check may be ignored. (We [officially advise using alternatives to...

@wfrierson No, you don't need to *remove* `renv`, just [deactivate it](https://rstudio.github.io/renv/reference/deactivate.html). That only changes the local `.Rprofile` file by commenting out the `source` line. Alternatively, just remove that file from...

@msperlin The build failure in the checks above is because ``` Error: 'load_builtin_calendars' is not an exported object from 'namespace:bizdays' ``` That generally means you're not locally using latest versions...

Thanks @wilsonfreitas, our check system has just been updated to do what above link says: *Allow global assignment operator if in RefClass statement*. Your package no longer fails that check...

@phuongquan You're right about the functions not having examples. That was a bug which has now been fixed, so thanks! You can ignore that result. The coverage issue is, however,...

Note: We're still working on a fix for the package coverage failure there - see package GitHub workflow for actual coverage in the meantime: 96%. Sorry for an inconvenience @phuongquan.

@maurolepore We've updated the automated checking in the meantime, so it now flags any submissions which have renv in activated mode, and require that to be de-activated for reviews to...

I think that this issue is best postponed for now and merged with development of [`ropenscilabs/deposits`](https://github.com/ropenscilabs/deposits). I'll open a parallel issue there for a single function which authors can then...