Morten Piibeleht

> This currently evals the module to Main, but there's no reason it couldn't eval to somewhere else. It looks like `Module(m)` puts it into `Main` too, right? There's quite...

LGTM, thank you!

> This was fixed by [#59725](https://github.com/JuliaLang/julia/pull/59725) Doesn't look like it, unfortunately. The difference here relative to the other issue is that we're specifying the type parameter. cc @KristofferC ``` julia>...

Generally, I think trying to use `pushDefault` makes sense. But I have a couple of concerns: 1. It will warn when `remote.pushDefault` is not set. However, it doesn't seem that...

I don't mind this, but personally I never follow the URLs, so implying that you _have_ to fill those two values in can be annoying -- I really just want...

> which URLs do you mean that you "never follow" The only difference between calling `genkeys` with or without arguments is the URLs it generates in the output. It's meant...

Moving the check to be earlier seems reasonable to me. I also wonder if this should happen before or at the time when we convert to MarkdownAST.

I have a slightly updated version of this, but it also needs a bit more work (which is also unfortunately unlikely to happen any time too soon): https://github.com/JuliaDocs/Documenter.jl/issues/1074#issuecomment-515477974

Do you have a link or an MWE? It looks like what you end up with in the at-eval block is incorrect. It sounds like you have a `Markdown.MD` object...

> that `MarkdownAST` declares that all subtypes are expected to be `mutable struct`, but here there are custom AST elements created, and those are declared just `struct`, and show ends...