Documenter.jl icon indicating copy to clipboard operation
Documenter.jl copied to clipboard

[docs] Clarify use of `DocumenterTools.genkeys` for out-of-repo deployment

Open giordano opened this issue 2 months ago • 4 comments

I believe the documentation as written now is quite ambiguous.

giordano avatar Nov 06 '25 18:11 giordano

I don't mind this, but personally I never follow the URLs, so implying that you have to fill those two values in can be annoying -- I really just want the key values. Could we easily accommodate both cases?

mortenpi avatar Nov 07 '25 10:11 mortenpi

@mortenpi I am confused by your comment (I might be parsing it wrong): which URLs do you mean that you "never follow", and how does this relate to the change @giordano is proposing"?

Are you suggesting something DocumenterTools.genkeys() for keys generated for out-of-repo deployment is fine? If so, what's the context?

fingolfin avatar Nov 07 '25 13:11 fingolfin

which URLs do you mean that you "never follow"

The only difference between calling genkeys with or without arguments is the URLs it generates in the output.

image

It's meant to just let you click on the URL to go to the right page, but I never actually use them myself. So I am not convinced it's good to imply here that you seemingly have to fill those arguments out, since it's a bunch of annoying typing for the user which they likely do not care about.

But I don't have a strong opinion -- if we feel that this is an improvement, we can merge this.

mortenpi avatar Nov 11 '25 06:11 mortenpi

Thank you for the explanation @mortenpi now I understand what you meant.

So yeah, without any arguments, it prints URLs like https://github.com/$USER/$REPO/settings/keys with literatlly $USER in there. Not sure what is misleading about that...

@giordano your thoughts?

fingolfin avatar Nov 11 '25 09:11 fingolfin