Morten Piibeleht

Results 540 comments of Morten Piibeleht

Sorry for the delay. I'm actually a little bit of two minds here (in addition to two hats.. but I'm wearing my JuliaDocs/Documenter open source one right now). I think...

In light of https://github.com/JuliaComputing/JuliaHub-Feedback/issues/161#issuecomment-2286367635, let's hold off on this for a few more weeks, until the changes have been deployed, and then figure out if/how we want to have this...

> I think this can be closed in light of [JuliaComputing/JuliaHub-Feedback#161 (comment)](https://github.com/JuliaComputing/JuliaHub-Feedback/issues/161#issuecomment-2730488751): > > > We're no longer rehosting docs and old ones should be de-indexed, so I believe this...

I can repro this. E.g. if you navigate to https://documenter.juliadocs.org/stable/#Package-Features ![image](https://github.com/user-attachments/assets/c6978652-7af8-4893-b184-5263469f091f)

> Ok, but that header isn't fixed right? It moves when scrolling(even at top/bottom of page). Do you mean the top bar? The UX problem here is that the heading...

Actually I would go one step further here and get rid of the notion of themes (from the reader's perspective). Just have "light mode" and "dark mode". And then package...

This looks great to me as well. > For testing, you could also modify some global variable and observe the side effect? A global variable seems like a good idea...

So, this is non-obvious, but caused by the `all` here: https://github.com/JuliaDocs/Documenter.jl/blob/e50da5d0744d6bc57e48cb7fc494d2701638fd9a/src/doctests.jl#L283 Both output _and_ expected output have to match before filtering is applied. I am unsure of the usecase, but...

So I was thinking about this a bit. We have 4 cases that can happen when we apply a filter to a doctest: 1. Both evaluated output and expected output...