Michael Mommert

Results 10 comments of Michael Mommert

Thanks, Michele! I will look into adding this feature soon. Do you happen to have an OSSOS reference that we can cite for this feature?

This is an interesting and non-trivial problem. Orbits for different objects use different parameters: ``` from sbpy.data import Orbit orbits = Orbit.from_horizons( '46P', 'designation', closest_apparition=True) print(orbits.field_names) for planet in (399,...

note to myself: I tried to get around this issue by joining the two tables, but the problem is that both `Time` and `Quantity` cannot be masked, which is necessary...

how about `github.com/NASA-Planetary-Science/sbpy-data`?

Thanks for providing this PR! A few things that I would like to see discussed/changed/added before I proceed with an in-depth review: * [ ] `sbpy.data.Orbit` handles orbits, so that...

Thanks, @shreyasbapat ! I will work on the review as soon as possible!

@shreyasbapat: have you tried installing `synphot` separately with: `pip install synphot`?

If you have a doctest that checks if your download succeeded, I think it's legitimate to skip it. However, in that case, you should have a dedicated test on the...

I added some links to the `from_horizons` docstring to clarify the default reference system for both orbital elements and ephemerides, as well as a short explanation on how to change...

Do we want to replace the currently used `ads` with `astroquery.nasa_ads`? You guys might have a better sense for this. Also, for now I deactivated the remote tests for `sbpy.bib`...