sbpy icon indicating copy to clipboard operation
sbpy copied to clipboard

Use astroquery.nasa_ads in bibliography module

Open migueldvb opened this issue 7 years ago • 5 comments

astroquery.nasa_ads now supports the new ADS API (https://github.com/astropy/astroquery/pull/1162).

migueldvb avatar Jun 20 '18 13:06 migueldvb

Do we want to replace the currently used ads with astroquery.nasa_ads? You guys might have a better sense for this.

Also, for now I deactivated the remote tests for sbpy.bib due to the same problems as in the pr referenced above. Let's see what they come up with...

mommermi avatar Aug 06 '18 17:08 mommermi

It would be good to use astroquery in sbpy.bib but it seems that currently the ADS export service is not yet supported in astroquery.nasa_ads (https://github.com/astropy/astroquery/issues/1422).

migueldvb avatar Apr 24 '19 03:04 migueldvb

Probably related to #326

jianyangli avatar Apr 27 '22 16:04 jianyangli

@mkelley @migueldvb Can you two take a look at this one and also #326 because it's affecting the normal function of sbpy for our v0.3 release. We should at least resolve #326 for the v0.3, if not switch to astroquery.nasa_ads for this release.

jianyangli avatar Apr 27 '22 17:04 jianyangli

OK, #326 was due to my not setting ADS token, and closed now. There is no urgency for this issue for v0.3 then.

jianyangli avatar Apr 27 '22 19:04 jianyangli