momchil-flex
momchil-flex
Let's get this in 2.0. Still a few to dos: - [ ] Move tidy3d-beta package to tidy3d on PyPI (not technically the goal of this PR, but otherwise we...
I don't exactly follow what's happening here, but we've been discussing improvements to Tidy3D's own [S-matrix tool](https://docs.flexcompute.com/projects/tidy3d/en/latest/notebooks/SMatrix.html). I would suggest eventually using this inside `write_sparameters`, but I guess even though...
> Nice We are trying to standardize the format where we store s parameters Yeah I think this is somewhat independent of Tidy3D internals, it will be entirely determined by...
So I just ran this and I get 90% coverage on the updater.. which seems pretty good? And some of the things that are not covered are very pedantic... For...
Looks good, I think some things may pop up while doing the backend implementation, but for now I just have these comments: - We'll see how this goes, but we...
> > * We'll see how this goes, but we may not have to restrict to single frequency. We have already introduced multi-frequency (boradband) sources for ModeSource and GaussianBeam and...
> I just added a `.from_field_data()` classmethod constructor in [this commit](https://github.com/flexcompute/tidy3d/pull/550/commits/c18d331716f001b5b222b40474b9922e7845e7c3). Note that it adds a dependency (through the type annotation) where `source.py` imports from `monitor_data.py`. I think this should...
Actually this is not exactly how this works, it is not exactly equivalent to the `load_from_group` / `save_from_group` in current develop. That is because current develop preserves the entire model...
> Note: in #535 you will be able to load an object stored within an hdf5 file (without loading everything) by supplying a path to `from_hdf5()` for example > >...
I think this works now yeah. The second (optional) request is to be able to only download part of the data. I think this may eventually be coupled with the...