Shashank Singh

Results 66 comments of Shashank Singh

@nanu1605 I think we'll need to add a line in both NEWS.md and changelog.md file stating that we've made a change in the function's name and why.

@Its-Maniaco I am not sure if this issue is active or not. Let's wait to hear from @robkooper and @infotroph.

@infotroph @mdietze I am still not sure if adding `.data$` is the right way to go here. Some context here would be very helpful. Another question is how is the...

@infotroph tried my best to update convert.input file.although I am not at all sure that form_file would be an ideal function to replace POSTFORM function. hhtr::POST might be the ideal...

> @mdietze @moki1202 > > 1. I tested this locally and discovered I gave some bad advice in the comments above, so I'm fixing in a local branch and will...

@nanu1605 just mentioning here the arguments that still need to be documented- - [x] myY - [x] maxval - [x] ic - [x] rate - [x] xnew - [x] pos.check...

@nanu1605 I don't think `data.land` would cause any `CI check` failure atleast in this PR. Maybe I missed something. Can you mention the lines you're referring to? Adding to this,...

@infotroph @dlebauer "base/remote- imports PEcAn.logger" when we say this ..does this mean we need to pass PEcAn.remote along with PEcAn.logger FUNCTIONS altogether to CRAN? was a bit confused about this.

Don't know if it's the right approach: move fqdn function to ' db ' package and move dbfiles.R to remote package. this might solve our problem.