Shashank Singh
Shashank Singh
@mauriciovasquezbernal I'll try completing this weekend.
> Hi, > > Could we make this optional and opt-out by default? > > ``` > {{- if .Values.config.xxx > ``` @alban changes added.
> We should really avoid using [hostPath](https://kubernetes.io/docs/concepts/storage/volumes/#hostpath) when not necessary. I'll change this to a local volume. Edit-1: Changes done!
> Hi! > > Thank you for switching to `local`! Can you please run `make generate-manifests` to propagate your changes to `pkg/resources/manifests/deploy.yaml`? > > Best regards. Already pushed with the...
@eiffel-fl I don't understand, do you mean using an empty directory volume here rather than defining a PV?
> Thinking more about it, I am wondering if we should not also add a flag `kubectl gadget deploy`. This way, we have the same set of options in both...
> > > Thinking more about it, I am wondering if we should not also add a flag `kubectl gadget deploy`. This way, we have the same set of options...
Hi @eiffel-fl apologies for the late reply, recently I've been very busy job hunting bu tI'll be pushing the updated code here very soon. I'll try finishing both my PRs...
@mauriciovasquezbernal @mqasimsarfraz can we simply check whether the gadget version that we get from the env var equals `KubectlGadgetVersion` and log warning accordingly?
@mauriciovasquezbernal Apologies. I didn't look into printVersionSkewWarning function completely. Now I see that it already checks the version from image and prints warning accordingly. Maybe I understood the issue wrong.