pecan icon indicating copy to clipboard operation
pecan copied to clipboard

Fix undeclared dependencies in /base/remote pacakge

Open moki1202 opened this issue 4 years ago • 3 comments

###DESCRIPTION

currently PEcAn.DB remains undeclared in /base/remote package. It's being used by remote functions in the following files-

  1. \remote\R\remote.copy.update.R
  2. \remote\tests\Rcheck_reference.log

###PROPOSED SOLUTION

Not determined yet. remote only uses two functions from DB and DB only uses two functions from remote, but both are deeply embedded and will be challenging to remove. May need to copy some functions between packages.

moki1202 avatar Jun 22 '21 09:06 moki1202

Don't know if it's the right approach: move fqdn function to ' db ' package and move dbfiles.R to remote package. this might solve our problem.

moki1202 avatar Jun 22 '21 09:06 moki1202

You can't move dbfiles.R to remote, it's core DB code and used in a lot of places. I think remote is just going to have to depend on DB (at least initially). So I'd instead focus on how to make DB not depend on remote (e.g. moving or duplicating fqdn is OK with me)

mdietze avatar Jun 22 '21 12:06 mdietze

This issue is stale because it has been open 365 days with no activity.

github-actions[bot] avatar Jun 23 '22 00:06 github-actions[bot]