pecan icon indicating copy to clipboard operation
pecan copied to clipboard

Published 20 hours ago • verified publisher icon PecanProject

Fixed Documentation warnings from PEcAn.emulator

Open nanu1605 opened this issue 3 years ago • 4 comments

nanu1605 avatar Jul 24 '22 16:07 nanu1605

@nanu1605 just mentioning here the arguments that still need to be documented-

  • [x] myY
  • [x] maxval
  • [x] ic
  • [x] rate
  • [x] xnew
  • [x] pos.check
  • [x] SSnew
  • [x] ycurr
  • [x] ynew
  • [x] isotropic
  • [x] exclude
  • [x] n1
  • [x] theta
  • [x] dim
  • [x] text_file

moki1202 avatar Jul 25 '22 07:07 moki1202

Hi @moki1202, I was searching for their description but wasn't able to find them. I was about to ask in the #cran channel regarding their description.

nanu1605 avatar Jul 25 '22 11:07 nanu1605

@infotroph @moki1202 Is something missing in data.land? the CI checks are failing because of it

nanu1605 avatar Jul 29 '22 08:07 nanu1605

@nanu1605 I don't think data.land would cause any CI check failure atleast in this PR. Maybe I missed something. Can you mention the lines you're referring to? Adding to this, let's take a pause on the documentation of above mentioned arguments that we discussed. As suggested by @infotroph these arguments "xnew", "ynew" etc ,could have different definition according to how they're being used in code. let's have a look at these again.

moki1202 avatar Aug 01 '22 05:08 moki1202