François Mockers

Results 430 comments of François Mockers
trafficstars

This code seems to have been removed in the rendering rework: https://github.com/bevyengine/bevy/tree/pipelined-rendering/pipelined/bevy_render2/src/camera

According to #2535, it's not! #2861 would add it but still waiting for reviews and merge. There's still the TODO: https://github.com/bevyengine/bevy/pull/2861/files#diff-4dee68290412f102be8ef381f19aa5f435836709d962ac0207680067f5442799R181-R184

You can either: * open a PR on @superdump Bevy fork https://github.com/superdump/bevy/tree/visibility to fix it there, which will include your fix in #2861 * check with @superdump if they could...

This PR doesn't compile in release on my mac ``` error[E0515]: cannot return reference to local variable `untyped` --> crates/bevy_render/src/render_resource/resource_macros.rs:57:9 | 57 | &$value | ^^^^^^^ returns a reference to...

I have a change stashed locally that does this and a bit more, but it's not finished yet because it's actually a bit more complicated than that. I don't think...

> Which of these would you like me to work on? I actually haven't found yet a fix that makes me happy, which is why I didn't open the PR....

something around frame metadata rather than globals?

> The time since startup value isn't really related to the frame though Oh you mean the frame start time 😄

This is very old code that hasn't evolved much since Bevy start... I would prefer to not made those public but rewrite them to be `From` implementations

Rather than try and make `winit` pass compilation, could you make it optional? It's only depended on in `bevy_winit`, which is itself optional. So it would be better to not...