Mitja P

For this dataset I also observed significant speedup of 6x. Original version hit 100 iterations limit while improved version converged after 17 steps.

`POST` is optional extension and might not be used. I recommend testing at startup and save result as a promise which is always evaluated on every request. If initial test...

Since we want to make as many breaking changes now rather than later, should we also extract datastores to separate packages for 1.x? (https://github.com/tus/tus-node-server/issues/61)

Is it too much work to have two packages for some (limited) time, one of which would be deprecated?

You are right. I completely missed this call. I did not encounter any issues, just got suspicious when I was looking at the code.

I'm reopening this as I think there is another possibility of unaligned memory access. In both cases there are fixed-size Eigen matrices as members and object is dynamically created using...

This PR does two things, it uses more modern CMake with targets and better manages dependencies between targets and add installation of config files. Do you think this shuld be...

https://github.com/alicevision/popsift/blob/74f705301257ca00e096f62978505c3d8e078e3e/src/popsift/s_extrema.cu#L203 https://github.com/alicevision/popsift/blob/f63d305131971c2cf96b43468304f1bfea25cb30/src/popsift/s_extrema.cu#L255 https://github.com/alicevision/popsift/blob/f63d305131971c2cf96b43468304f1bfea25cb30/src/popsift/s_extrema.cu#L485 I also don't think this `2.0f ` factor should be here. I understand that it is here just to negate some multiplication `0.5f` which is made in...

Is there a reason that values values in textures are multiplied by `255.0f`? Float values are usually in range [0-1]. I don't see any reason for doing so and I...

I think there might be an error in some cases. In case where algorithm reaches MAX_ITERATIONS then variable `n` might have been modified in `ModeFunctions::refine` by `-1` or `+1` if...