avro
avro copied to clipboard
apache
AVRO-3088: use modern CMake style with config file
I'm proposing some changes to CMake that would also install config file which makes it easier for downstream libraries to use avro as dependency.
Make sure you have checked all steps below.
Jira
- [x] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3088
- In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
Tests
- [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters (not including Jira issue reference)
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
This PR does two things, it uses more modern CMake with targets and better manages dependencies between targets and add installation of config files. Do you think this shuld be two separate PRs?
If I remember correctly this is it. I was waiting for a feedback before removing a draft label.
Okay, thanks! I'll take a closer look as soon as possible.
If you could rebase it on the top of current main, it would be great.
Also if you could split it into two PRs as you suggested above, it would be much easier to review!
If you don't have time for doing this, let me know and I can do this myself