Mitja P

Results 34 comments of Mitja P

> @yhc44 Do you want to use this feature in your SPA app? Because SPAs would not benefit from PKCE. > PKCE is only useful in public native clients (mobile...

Just use relative location and should work with uppy.

This still needs changes.

Every store has identical code for reading and validating headers, generating file name and checking for errors. I think this is not the responsibility of a store, so I moved...

@Murderlon I think this PR is still worth working on. I can do some more work but my main issue is that this change breaks almost all existing tests. Is...

I've made rough changes so that you can have better understanding of what changes I propose. Main goal is still to simplify stores. Store's only responsibility now is to implement...

I think this is ready for review. All tests are now passing.

@Murderlon I think this PR is now ready for some serious real world testing. On the side note: CI test on this PR is running tests against `master` branch.

I'm not really sure why this last test is failing. It works for me with node 14 and 16. Also the code looks like it should be rejected as expected....

> > I'm a bit confused why CI runs successfully on Node 16.x but not on 14.x? I don't see any errors about using something unsupported. I skipped GCS test...