Michael Solomon comments

Results 282 comments of


                                            Michael Solomon

Fix invalid `if` condition in `OverriddenClientRequest` when `interceptors` is made empty

@ekohilas, when you run your original commit, do the tests pass?

Fix invalid `if` condition in `OverriddenClientRequest` when `interceptors` is made empty

@ekohilas From what I see, `nock` probably relies on this behavior, and I can't fix it now. Feel free to update this PR if you can. 🙏

Fix invalid `if` condition in `OverriddenClientRequest` when `interceptors` is made empty

@ekohilas we use `mocha`, so to can use `it.only`

Fix invalid `if` condition in `OverriddenClientRequest` when `interceptors` is made empty

Oh.. sorry, probably need to update it. `npx mocha tests/*` with `only` should do it

Fix invalid `if` condition in `OverriddenClientRequest` when `interceptors` is made empty

@ekohilas Thank you! Because this contains a change in the tests, it means that the behavior changed, which is a breaking change. Is this a fix for a regression bug,...

Regression on V14: monkey-patching breaks with some libraries

What error do you get? can you please share a minimal reproducible code? (no ts, no stripe)

Regression on V14: monkey-patching breaks with some libraries

Closing this for now. Feel free to reopen with reproduction.

Expose "Content-Encoding" handling publicly

Hey there :) Can I help merge this in?

Nock sometimes incorrectly represents protobuf-encoded binary requests as utf8 strings instead of hex

Can you please try with `nock` 14 (in beta; we will release it soon)? p.s: I couldn't understand how to run the `codesandbox`

Nock sometimes incorrectly represents protobuf-encoded binary requests as utf8 strings instead of hex

nm.. I ran it on my machine :) So, if I understand correctly, the string `00` is a valid protobuf in both `hex` and `utf8` encoding, so you can't figure...