Michał Dudak comments

Results 446 comments of


                                            Michał Dudak

[docs][autocomplete] Fix duplicate autocomplete id

Why do we even need the explicit `id`? It doesn't add anything of value to the demo.

[docs][autocomplete] Fix duplicate autocomplete id

I understand the id is needed to wire the input to the label, but even if we use React 17 and automatically set the id only on the client, it's...

Extra parens inserted around JSX after attributes are added

> Do the extra parentheses actually introduce bugs/regressions into migrated mui projects, or is it more of an aesthetics thing? It's impossible to say right now. We haven't released our...

[Autocomplete] Pass getOptionLabel as a parameter to renderOption

I'm OK with `useTheme`, but let's also add a comment explaining why it's needed.

[TextareaAutosize] Unstable height when rendered in a Next.js RSC page

We don't have access to the DOM node on the server (as it doesn't exist there), so it's impossible to measure its height. I can't really think of another fix...

[TextareaAutosize] Unstable height when rendered in a Next.js RSC page

Working on the [Base UI components' API changes](https://github.com/mui/base-ui/discussions/157) is our top priority at the moment. Since these changes may affect the internals of the components, we don't want to focus...

[Autocomplete] useAutocomplete hook disabled option can be clicked

> Do you think preventing selecting a disabled option could be provided out of the box? Yes, I think it should work similarly to how Base UI's Select works (likely...

[Input] Reorganize the Input and Textarea components

This comes from @colmtuite's audit: https://www.notion.so/mui-org/base-ui-Audit-0241b1291ff24c278ab1473f874c47d0?pvs=4#67e90e0c43fa4ac6a42f9c12775cfb25 It may turn out that the Input component is not needed in Base UI, and the native HTML input will suffice — we haven't...

[Input] Reorganize the Input and Textarea components

On the last team meeting we agreed to postpone this decision when we're closer to the release. We'll see if the browser support is decent enough for us to deprecate...

[Select] Shows the first item to be selected when initial value is blank or null and the menu popover is not aligned properly with the Select

The darker background indicates a highlighted item - that is, the one that will get selected when you press Enter. As for the misalignment - it does look like a...