storefront-angular-starter icon indicating copy to clipboard operation
storefront-angular-starter copied to clipboard
verified publisher icon vendure-ecommerce

fix angular dependencies conflicts

Open mkashifaslam opened this issue 2 years ago • 2 comments

mkashifaslam avatar Jul 23 '23 05:07 mkashifaslam

Hi! Thanks for the contribution! Unfortunately another change I just merged means this has some conflicts to resolve. Probably the needs to have the other changed merged and then run yarn again to update the lockfile.

By the way, what conflicts is this resolving?

michaelbromley avatar Jul 25 '23 07:07 michaelbromley

Hi! Thanks for the contribution! Unfortunately another change I just merged means this has some conflicts to resolve. Probably the needs to have the other changed merged and then run yarn again to update the lockfile.

By the way, what conflicts is this resolving?

I was facing angular build issues when ran it locally so I resolved those issues and tested it and everything is working fine now, so t I thought it's better to merge these changes in main.

kashifaslamveeve avatar Jul 25 '23 07:07 kashifaslamveeve