New version?

[kloczek]

Just found that 1.0.2 is failing in test suite

+ /usr/bin/make -O -j48 V=1 VERBOSE=1 check
TEST_SSL=0 ./test.sh
daemonize yes
pidfile /tmp/tmp.pLTwdZxMVK/hiredis-test-redis.pid
port 56379
bind 127.0.0.1
unixsocket /tmp/tmp.pLTwdZxMVK/hiredis-test-redis.sock
#01 redisContext uses injected allocators: PASSED
#02 redisReader uses injected allocators: PASSED
#03 Format command without interpolation: PASSED
#04 Format command with %s string interpolation: PASSED
#05 Format command with %s and an empty string: PASSED
#06 Format command with an empty string in between proper interpolations: PASSED
#07 Format command with %b string interpolation: PASSED
#08 Format command with %b and an empty string: PASSED
#09 Format command with literal %: PASSED
#10 Format command with printf-delegation (int): PASSED
#11 Format command with printf-delegation (char): PASSED
#12 Format command with printf-delegation (short): PASSED
#13 Format command with printf-delegation (long): PASSED
#14 Format command with printf-delegation (long long): PASSED
#15 Format command with printf-delegation (unsigned int): PASSED
#16 Format command with printf-delegation (unsigned char): PASSED
#17 Format command with printf-delegation (unsigned short): PASSED
#18 Format command with printf-delegation (unsigned long): PASSED
#19 Format command with printf-delegation (unsigned long long): PASSED
#20 Format command with printf-delegation (float): PASSED
#21 Format command with printf-delegation (double): PASSED
#22 Format command with invalid printf format: PASSED
#23 Format command by passing argc/argv without lengths: PASSED
#24 Format command by passing argc/argv with lengths: PASSED
#25 Format command into sds by passing argc/argv without lengths: PASSED
#26 Format command into sds by passing argc/argv with lengths: PASSED
#27 Error handling in reply parser: PASSED
#28 Memory cleanup in reply parser: PASSED
#29 Can handle arbitrarily nested multi-bulks: PASSED
#30 Can parse arbitrarily nested multi-bulks correctly: PASSED
#31 Correctly parses LLONG_MAX: PASSED
#32 Set error when > LLONG_MAX: PASSED
#33 Correctly parses LLONG_MIN: PASSED
#34 Set error when < LLONG_MIN: PASSED
#35 Set error when array < -1: PASSED
#36 Set error when bulk < -1: PASSED
#37 Can configure maximum multi-bulk elements: PASSED
#38 Multi-bulk never overflows regardless of maxelements: PASSED
#39 Works with NULL functions for reply: PASSED
#40 Works when a single newline (\r\n) covers two calls to feed: PASSED
#41 Don't reset state after protocol error: PASSED
#42 Don't do empty allocation for empty multi bulk: PASSED
#43 Can parse RESP3 verbatim strings: PASSED
#44 Can parse RESP3 push messages: PASSED
#45 Returns error when host cannot be resolved: PASSED
#46 Returns error when the port is not open: PASSED
#47 Returns error when the unix_sock socket path doesn't accept connections: PASSED
#48 Don't fail when redisFree is passed a NULL value: PASSED
#49 Don't fail when freeReplyObject is passed a NULL value: PASSED

Testing against TCP connection (127.0.0.1:56379):
#50 Is able to deliver commands: PASSED
#51 Is a able to send commands verbatim: PASSED
#52 %s String interpolation works: PASSED
#53 %b String interpolation works: PASSED
#54 Binary reply length is correct: PASSED
#55 Can parse nil replies: PASSED
#56 Can parse integer replies: PASSED
#57 Can parse multi bulk replies: PASSED
#58 Can handle nested multi bulk replies: PASSED
#59 Can pass NULL to redisGetReply: PASSED
#60 RESP3 PUSH messages are handled out of band by default: PASSED
#61 We can set a custom RESP3 PUhiredis-test: test.c:151: send_hello: Assertion `reply != NULL && reply->type == expected' failed.
./test.sh: line 78: 1481970 Aborted                 (core dumped) ${TEST_PREFIX:-} ./hiredis-test -h 127.0.0.1 -p ${REDIS_PORT} -s ${SOCK_FILE} ${SSL_TEST_ARGS} ${SKIPS_ARG}
make: *** [Makefile:218: check] Error 134

The same with master is OK.

Do you have any plans to make new releasesoon? 🤔

[stanhu]

@michael-grunder Yes, would you mind tagging a new release?

[michael-grunder]

Yes, I think it's time for a new version.

I need to go through all of the changes since v1.0.2 to make sure I don't include any that are technically breaking, although off the top of my head I don't think there are many of those.

The only other question is whether to tag a release candidate first to flush out any hidden nasal demons.

[michaeloliverx]

There don't seem to be any wheels for Python 3.10 on PyPi, would it be possible to also get those when cutting a new release?

[zuiderkwast]

@michaeloliverx Python? There is nothing Python in this repo. What am I missing?

[michaeloliverx]

@michaeloliverx Python? There is nothing Python in this repo. What am I missing?

Sorry my bad, the official Redis client for Python has an optional extra package hiredis (which is a Python wrapper of this library). I was looking for https://github.com/redis/hiredis-py.

Please ignore me :)

[michael-grunder]

Closing in favor of #1131