Matt Holt comments

Results 1992 comments of


                                            Matt Holt

Caddy is not throwing an error on MacOS if address is already in use

I've noticed that quirk about macOS. Kinda weird/cool I guess! It also doesn't require privileges to bind lower ports. Not sure that this is a Caddy issue. :man_shrugging:

Stale OCSP response and "unable to write OCSP staple file" error

Thanks for opening an issue! We'll look into this. It's not immediately clear to me what is going on, so I'll need your help to understand it better. Ideally, we...

Stale OCSP response and "unable to write OCSP staple file" error

We already do a check on the storage system: https://github.com/caddyserver/certmagic/blob/3bad5b6bb595b09c14bd86ff0b365d302faaf5e2/config.go#L1162-L1200

Stale OCSP response and "unable to write OCSP staple file" error

Oh... that's a good point. And an unusual use case. I think in order to properly fix this we should implement the TODO: ``` // TODO: this is not necessary...

http3 breaks SSE

That's odd. I've asked for a minimal reproducer in the forum thread.

Including matcher in 'handle_response' line has confusing error

Ah thanks. @francislavoie This was from about 2 years ago; maybe it's time to revisit while we're at it? The previous line says `// TODO: Remove this check at some...

metrics: scope metrics to active config, add optional per-host metrics

I don't fully understand the metrics aspects, but if this works, that's big if true, yeah? I will defer to others more proficient with the metrics libs, but if it...

filesystem changes

Nit, but should it be `file_systems`? (Since it's two words)

[reverse_proxy] active_health check to http endpoint does not work when upstream is via ssl/tls

I don't know if it's a good idea for a health check to use a different port, let alone a different protocol, than the actual requests. :thinking: It kind of...

Use HTTP tracer if env var is set

Thanks for working on this. We'll revisit this shortly as we prepare the 2.9 beta releases! In the meantime how would you feel about resolving the merge conflicts