Matt Holt
Matt Holt
Yeah we can probably merge it -- but first the go.mod and go.sum changes should be dropped, and we should update it with the latest in `master` first. @trajano Any...
Alrighty. @PKeidel Do you want to make a PR?
The big problem/question is, what are we going to do about it? It's too late, by the time most placeholders are evaluated, to do anything with the error. Fail the...
Ah, you mean Caddyfile placeholders? `{$VAR}` is evaluated when the Caddyfile is adapted to JSON. `{env.VAR}` is what it gets adapted to and is evaluated at runtime. The problem is...
Why do you need POSIX/Docker syntax?
We don't really deal with keepalives ourselves, we just pass the value onto the Go standard library's HTTP transport: https://pkg.go.dev/net/http#Transport To be clear, you're talking about HTTP keepalives, right? Not...
> I think it's still worth thinking about a way to state that in the docs, as it does cause issues and the root cause is hard to figure out....
We could try it. If it doesn't break any tests that's probably a good sign as well. I also wonder if this should be reported as a bug to the...
Thanks! Is there a reason we need two? Like, why not just use the new `memoryStorage` for testing too?
Hmm. I still wonder if we can just use the one for both. (In other words, keep the new `memoryStorage` type, and just use it instead of the new `testingMemoryStorage`...