Matt Holt comments

Results 1992 comments of


                                            Matt Holt

matcher format for multiple sites share same definition

We should probably state that in the docs: there should be a space after the comma, not before. What you have there looks weird IMO :innocent: I'm going to transfer...

matcher format for multiple sites share same definition

We don't actually want "fault tolerant" Caddyfiles, we want consistent ones :slightly_smiling_face: So the current behavior is correct, but we can clarify the specifics in the docs.

reverse proxy: rewrite requests and responses for websocket over http2

Very neat, nice work @WeidiDeng :100:

tls: certificates auto renewal will become stuck if issuer is changed between config reloads

Thanks for the report. I know you did in Slack, but could you share your logs here too? For the record, so as I go to fix I can ensure...

tls: certificates auto renewal will become stuck if issuer is changed between config reloads

Interesting, that's good, but I don't know why 😅

add documentation for output file log mode option

Thanks for your thorough work on this enhancement. :+1:

add documentation for output file log mode option

Sorry about the conflict here @ririsoft -- I'll resolve the merge conflicts and merge this in so you can still get credit. I think both changes have good parts.

core: add `iface` as network type

This is interesting, but it's a weird violation of abstractions. The bind directive typically describes the _socket_ not the interface. Hence you can bind to tcp/udp/unix and an address, but...

core: add `iface` as network type

@MayCXC I think I like that more. :thinking: Still a weird concept overall to me :smile:

Implement issue #6296 passing FDs / socket activation

@MayCXC Actually I really like the sound of that. If it's not too much trouble I would like to see it! I was about to merge this -- but again,...