Matthew
Matthew
Update; Fixing this with a global unitary folding under pull request #1327.
Added circuit folding (global unitary folding) in https://github.com/qiboteam/qibo/pull/1327
Just curious, would it be helpful to have a call to understand how the algorithm works? It might make it easier to review the code.
@HuberyMing If you're doing the changes locally, you could do `pip install pre-commit` followed by `pre-commit install` inside your environment. Each time you do `git commit -m "message"`, the pre-commit...
> `global_unitary_folding` is missing in the docstrings of `ZNE()`. Thanks @AlejandroSopena for reviewing the code. I will amend according to your suggestions but will take some time as I am...
Hi @MatteoRobbiati and @AlejandroSopena. Sorry for the late reply, I just returned to work after mandatory national service. Just wondering if we can expedite the merging of this PR. We're...
Hi @BrunoLiegiBastonLiegi! Most of the issues you've raised have been resolved. Thanks so much for looking through the code and providing helpful comments. The code that I have in my...
> Hi @mho291, can you push your latest changes so we can continue reviewing from there please? Just did. Sorry for the delay. I planned to push yesterday but I...
Hi @AlejandroSopena and @BrunoLiegiBastonLiegi, the code is done! All tests have passed except the pre-commit.ci. Any idea what might be the problem here? @shangtai and I couldn't figure out. Thanks...
@MatteoRobbiati , @andrea-pasquale , thank you for the heads up and the guidance. I don't think I have installed pre-commit locally, allow me to do just that moving forward. :)