Matthew

I have split up the functions of PEC in the update. Gate set tomography has been added to src/qibo/validation. The functions for calculating the inverse noise, obtain quasi probabilities, and...

> @mho291 could you please open another PR with just the tomography? As discussed during the last meeting, this simplifies review and tests. Will do!

> @mho291 After you address my latest docstring comments, this is ready to go on my end. Thanks a lot @renatomello , I have modified the docstring accordingly.

Maybe we can ignore the tests for TSP, since we might move it to qibo comb optimisation. Right @shangtai)?

Hi @MatteoRobbiati, I need some advice with this. When I run the pytests locally, they pass. But here, they always run into dimension error: ``` FAILED tests/test_tomography_gate_set_tomography.py::test_GST[qiboml-pytorch-False-target_gates0] - RuntimeError: permute(sparse_coo):...

> > Could there be an issue with `qiboml-pytorch`? > > Ehi @mho291! Thanks for asking :) I tested locally your branch and in my case I get the same...

I have added an option for `ancilla=True` or `ancilla=False`. When `ancilla=True`, it will simulate a resetting to |0> state by disabling the line `circ.add(_prepare_state(k, nqubits))`. This is crucial to do...

Sorry, please hold the review, I will need to modify the current changes to increase the functionality!

> Sorry, please hold the review, I will need to modify the current changes to increase the functionality! The code is now ready for review! :)

Thanks @BrunoLiegiBastonLiegi for the detailed review. I will need some time to answer these. Yes, the initial idea was to add support for Unitary gate alone. But to enable support...