Maximilian Hils

Results 341 comments of Maximilian Hils

Hi there! 😃 Could I ask what your specific use case for a 32 bit binary is? For "niche" platforms, my default recommendation would be to install mitmproxy from PyPI,...

https://github.com/mitmproxy/mitmproxy/actions/runs/7878070568/job/21495523975?pr=6653#step:5:74 Test is failing because `test_multipart` is not covering line 17. Only test_api does. We are (a bit too) strict here... Cheap fix is to list http_message directly as an...

Thanks for filing this! We should fix the root cause here (negative durations) and not apply bandaids.

More concretely: We currently seem to use client/server-provided timestamps. We shouldn't do that at all, but use local (trusted) timestamps.

Did you see https://docs.mitmproxy.org/stable/howto-transparent/? Alternatively, WireGuard mode might be easier to set up. :) On Sat, Feb 3, 2024, 16:20 Hallison Boaventura ***@***.***> wrote: > Due to a missing extra...

https://github.com/mitmproxy/mitmproxy/blob/main/test/mitmproxy/proxy/layers/http/test_http.py would be a good fit. On Thu, Feb 1, 2024, 11:24 Ha Anh Vu ***@***.***> wrote: > Where should the test be added? > > — > Reply to...

The event hook name is derived from the class name. FooBar -> foo_bar. Does that make sense? :) On Thu, Feb 1, 2024, 18:43 Ha Anh Vu ***@***.***> wrote: >...

Sorry for the long turnaround. ``` > reader, writer = await asyncio.open_connection( *command.connection.address, local_addr=command.connection.sockname, E TypeError: mock_OSError() got an unexpected keyword argument 'local_addr' ``` This error here is because `mock_OSError`'s...

@abbbe: this is not super complex, so feel free to just take this over and submit a PR with the final necessary touches on top. :)

Please open a new pull request with the proposed changes and I'm happy to take a look! :) On Fri, Apr 12, 2024 at 6:19 PM Alexandre Bezroutchko < ***@***.***>...