Maximilian Hils

Results 341 comments of Maximilian Hils

FWIW, `arbtt-dump` crashes on "Skype™ - username" on Windows, so maybe that is why: ``` PS > arbtt-dump.exe 2018-02-20 20:53:36 (688ms inactive): ( ) \Device\HarddiskVolume4\Windows\explorer.exe: Program Manager ( ) \Device\HarddiskVolume4\Program...

> The binaries are all kept at https://uploader.codecov.io/, so you can pin to any one you want. To clarify, you recommend that we download, verify, and invoke the binaries manually...

> Yes. It was pointed out to me that I misunderstood your request / forgot which repo I was on. :D All good. Thanks for confirming. :-) > Given that...

That's a great first step, but unless the binary hashes are checked the action still depends on the integrity of https://uploader.codecov.io/. For example, someone could sign a malicious binary with...

How do you start mitmproxy and how do you invoke cURL?

Thanks for raising this! The relevant configuration is all in `addons/tlsconfig.py`. I'd be happy to merge a PR that makes mitmproxy look more like the current client or a hardcoded...

> I think this approach is not acceptable to be applied to general mitmproxy traffic. If this would be the route we take then this needs to be an option...

Thanks for the very clear root cause analysis! 😃 I will see if I can adjust the CSS to fix this without adding a dummy element, but that is just...

Ah, even simpler - thanks for updating this! If you could run `npm test -- -u` to update the snapshots this looks good to merge!

Thank you again for the contribution! 🍰