Maximilian Hils

Results 341 comments of Maximilian Hils

It looks like urwid is very much maintained again, which is awesome to see! 🎉🎉🎉 Could you test urwid with urwid 2.6.6 and report back if there are any issues...

Great, thanks! I'll test Windows when I get to it these days, so far it looks like we can switch back to stock urwid thanks to @penguinolog's awesome maintenance efforts...

I'd be inclined to say that this should be possible without a third-party library. But more importantly, the flow table is a really core UX element and we shouldn't rush...

Yes, basically that. I'm not saying it's a better UI/UX, just pointing out there are other options and we should look at existing work. :)

My suggestion would be to look at what others are doing and write that up. Before writing a single line of code. 😉

For UDP mode, we have fixed this as follows: https://github.com/mitmproxy/mitmproxy/blob/10.2.2/mitmproxy/proxy/mode_servers.py#L294-L310 We should probably do the same for WireGuard :)

> but it's not straightforward since here we simply propagate the value and call `updateOptions` Yeah, I think that's what we need to change! How about we change `StringSequenceOption` so...

We don't mirror attributes such as key size or algorithms because we don't want to mirror insecure configurations. So this is kind of expected behavior. The other part is the...