Mark Hammond

Results 678 comments of Mark Hammond

> What if the shared/common crate also contained some functions? `shutdown()` and `rc_log::log()` would be good candidates. Maybe that makes it substantial enough to for a .udl file. Yeah -...

> doh - `thread 'main' panicked at 'no support for external types yet'` - IIUC, @bendk added support for kotlin recently, but swift doesn't yet have support, so this can't...

SGTM - I rm that dir manually as a matter of course anyway.

> @mhammond and I have been discussing updating the `places::run_maintenance()` function to do more to reduce disk space by pruning unneeded data. Maybe we should also pick this one back...

> * If these issues are expected, then I think we should update `noteHistoryMetadataObservation()` to not report them The intention is that it already does - [here](https://github.com/mozilla-mobile/android-components/blob/01012c16f9e3aab667aaa1ad9065d87bf1bad9ce/components/browser/storage-sync/src/main/java/mozilla/components/browser/storage/sync/PlacesHistoryStorage.kt#L275-L288) it checks for...

We are seeing these in the wild - eg, https://sentry.prod.mozaws.net/operations/fenix/issues/6957530/, but I'm confident I've seen others before.

> "Database or disk is full" Oops, yes, I must have copied the wrong issue URL :) But there are certainly sentry issues for "image is malformed"

Yeah - #4214 isn't trivial, and updating places to `open_database.rs` isn't either - but they can be done mostly in parallel. I agree we should get to this sooner rather...

I wonder if we can work out *how* it's malformed without leaking the origin? I wonder if the new error reporting might help here?

> I need to understand the sync15 / sync15-traits split better to comment on this one. Couple questions here: > > * What was the motivation behind the split? I...