application-services icon indicating copy to clipboard operation
application-services copied to clipboard

UrlParseFailed errors in noteHistoryMetadataObservation()

Open bendk opened this issue 3 years ago • 1 comments

We're currently getting about 100-150 of these errors a day in sentry. That's not a huge amount, but it seems like we should do something about it.

  • If these issues are expected, then I think we should update noteHistoryMetadataObservation() to not report them
  • If they're unexpected, then we should fix the code somehow.
    • Maybe update places to handle these URLs?
    • Maybe update the Fenix code to not try to record these URLs?

┆Issue is synchronized with this Jira Task

bendk avatar Apr 19 '22 16:04 bendk

  • If these issues are expected, then I think we should update noteHistoryMetadataObservation() to not report them

The intention is that it already does - here it checks for an invalid Url before calling our component. canAddUri is at the end of that same file, and while it relies on a different parser than we do, I believe most of those sentry errors should have been filtered. So I'm not sure what is going on there.

  • If they're unexpected, then we should fix the code somehow.

We had the same issue with the regular history items - I think that they are "expected" in so far as some code assumed that whatever text is in the address bar in some cases is valid, but mistyping a URL in some way would trigger this.

IOW, the fact that noteHistoryMetadataObservation() in a-c might be called with an invalid URL is expected, but it's unexpected that they should end up making it to the rust code.

mhammond avatar Apr 20 '22 04:04 mhammond

#5304 has made this redundant.

mhammond avatar Oct 06 '23 20:10 mhammond