Mark Hammond

Results 678 comments of Mark Hammond

See also [this comment](https://github.com/mozilla/uniffi-rs/pull/416#discussion_r683023354) and [this comment](https://github.com/mozilla/uniffi-rs/pull/416#issuecomment-893327808) and related discussion about how `wasm-bindgen` takes a somewhat similar approach but jumps through many hoops to embed this information in the binary...

Our policy is at https://github.com/mozilla/uniffi-rs/blob/main/docs/policies/rust-versions.md, which implies 1.59.0 is the min version we want to support currently.

> Given the current `rust-toolchain.toml` contains 1.60 (https://github.com/mozilla/uniffi-rs/blob/main/rust-toolchain.toml), that seems unlikely 😄 Right - that's the "uses" version, which m-c is also currently on. The m-c "requires" version is 1.59...

I'll update the docs to make that clearer, but: * uses is what all the CI and release engineering machines actually use. * requires is what some downstream packagers (eg,...

I'm not sure we can really help you here without knowing exactly what you are trying to test nor what your android configuration is. Stand-alone tests in android-studio also isn't...

This sounds like a reasonable idea, thanks! Is there a good reason to not just quote every name instead of just reserved words?

> if you were unfortunate enough to design an API for one language, (e.g. you use `val` in Swift), then decide to adopt Kotlin I'm not quite sure I agree...

Thanks Ben - that's my take on the formatter too - instinct is to make it pretty, but I can't justify that when I think more about it, especially now...

> So after all the consensus is to generate uglier code, right? Yep, thanks for your patience!

Thanks for the report - I'm not hugely familiar with Kotlin and haven't yet read this report in detail, but is it possible it's a dupe of #1020? For additional...