Mark Hammond

Results 678 comments of Mark Hammond

> How could that last part work? We already have [code](https://github.com/mozilla/uniffi-rs/blob/main/uniffi_bindgen/src/scaffolding/templates/CallbackInterfaceTemplate.rs) that inputs a callback interface handle from the foreign side and creates a `Box` from it. I tweaked the...

Thanks James, that's an interesting question! > Now we have the possibility of UDL files importing other UDL files Where did this come up? I can't see why this would...

FWIW, https://sql.telemetry.mozilla.org/queries/73067#183005 is showing send tab success nose-diving on Android - which prompted me to see how it works for me, and logcat shows what Ryan was getting at: >...

I don't think this is the same issue - if I'm reading [the client code correctly](https://github.com/mozilla/application-services/blob/4f139a9403e14b394195ff1f577f7afaa9a3752a/components/push/src/internal/communications.rs#L265-L282), the check for a `uaid` happens after we've checked for a 401. A recent...

rkv is now using `thiserror` so I don't think this is relevant any more? (In particular, the advice at https://github.com/mozilla/nimbus-sdk/blob/da8d27cdba0d908befbfc99af1b5ef5b5f042d1e/nimbus/src/error.rs#L56 now works with 0.17.0)

Note that this bug is not about showing icon on Fenix, it's about Fenix not supplying the icon when supplying synced tabs for use by other devices. IOW, *desktop* can't...

I forgot about this PR, but it still seems worthwhile. I was reminded about it when a very similar change by @Mugurell caused conflicts, so they seem like a good...

Is it installed "globally"? The dll paths in the registry probably need to be pointing to ones in the system32 directory. Other than that though, I've no idea.

The added registry entries will point to pythoncomxx.dll - if that's not in system32, there's a good chance explorer.exe will not be able to locate it and everything it depends...