Michał Gołębiowski-Owczarek comments

Results 875 comments of


                                            Michał Gołębiowski-Owczarek

Custom <select> directive: Transclude and replace <option>s not working in IE9

I'm not convinced we'll fix it given age of the ticket. But for anyone interested, JSFiddle no longer works in IE 9 so I ported the test case to JS...

Migrate the Firefox version to a WebExtension

@schalkneethling The last YSlow version was released 4.5 years ago. The last commit landed 3.5 years ago. I think it's safe to assume this project is not maintained anymore.

git commit subcommand fails on Windows 10 (probably due to ' ' instead of " ")

Thanks; would you want to submit a PR with the fix?

git commit subcommand fails on Windows 10 (probably due to ' ' instead of " ")

It looks like `shell-quote` doesn't support Windows: https://github.com/substack/node-shell-quote/issues/38#issuecomment-527465696

git commit subcommand fails on Windows 10 (probably due to ' ' instead of " ")

Although, there was a PR adding Windows support almost 2 years ago: https://github.com/substack/node-shell-quote/pull/34 I'm not sure what the problem is then.

Drop the `this` binding altogether

Yet another argument in favor of dropping the unary form is it will be less controversial for the general public to swallow the binary form and it poses less spec...

jqLite text() function has different behavior then jquery text() function

This actually affects way more APIs than just `.text()`. We'd have to review them all & update.

jqLite text() function has different behavior then jquery text() function

Since we're reaching feature freeze, this is a won't fix at this point. Sorry!

3.2/3.3 Deprecations

Everything here has now been documented. I've also verified all deprecated APIs from 3.4-3.6 have also been documented. Closing!

developer.mozilla.org Node.nodeType link changed

This has been fixed independently.