Michał Gołębiowski-Owczarek

Results 713 comments of Michał Gołębiowski-Owczarek

Thanks for noticing the `checkGitUrls` option was undocumented, I can't believe I've missed it! I've landed that change & released 0.9.2. As for the `depsDir` feature, it seems to me...

I agree it’d be useful in some cases. But I don’t have time to do it myself at the moment; PRs (with tests) welcome.

As far as I understand, `npm ci` is meant for CI systems, not for running on a local machine, therefore `npm install` is still applicable. `npm ci` is also mainly...

I'm fine with this being an option, I think `npm install` should still be the default. Perhaps a new `packageInstallCommand` being `"install"` by default would solve the issue? You'd be...

@jackgeek There's already the `packageManager` option that controls which package manager to use. This is needed because some of them use a different folder for their dependencies (e.g. Bower uses...

Yeah, I’d use Prettier if was setting up the repo now. I’m fine with a PR that introduces it but I think you’d first need a PR to my eslint-config-mgol...

@jackgeek I went ahead & updated `eslint-config-mgol` & introduced Prettier to `check-dependencies`. Hopefully the setup is now more to your liking. :)

@OliverJAsh Mostly in that the check is blazingly fast: ``` $ time check-dependencies check-dependencies 0.14s user 0.02s system 105% cpu 0.156 total ``` Meanwhile: ``` $ time yarn check yarn...

Thanks for the report. How are you handling installing packages in a directory named differently than `node_modules` and without a separate `package.json`? I see a potential problem here. Wouldn't it...