Michał Gołębiowski-Owczarek

Results 875 comments of Michał Gołębiowski-Owczarek

@Splaktar At this point, when AngularJS is in LTS mode and in a year or so support will stop completely, I don't think it makes sense to focus on any...

Thanks for the report. I think this is written in a way that doesn't really work with elements but with classes so you need to prepend a dot to the...

Thanks for the report! It would be good to have links to API sites' bug trackers there as well. What do you think, @jquery/content?

Hmm, it should be enough to wrap https://github.com/mgol/npm-bump/blob/e665175404c767d7fc986ccdfcc64690831b0c67/lib/cli.js#L86-L89 in try-catch and do the rollback on error. Wrapping more things would be problematic as it `npm publish` succeeded and next Git...

Or maybe `npm publish` should be moved to be the last operation so that we always can fully rollback unless we finish all remote operations.

I have the same issue applying this PR: https://github.com/andywer/threads.js/pull/470 to my local installation of the `threads` package. It does seem `package.json` may erroneously be excluded...

It seems this has already been covered here: https://github.com/ds300/patch-package/issues/128#issuecomment-467558298

For the record, running: ``` npx patch-package --exclude '^$' threads ``` worked for me.