Michał Gołębiowski-Owczarek

Results 875 comments of Michał Gołębiowski-Owczarek

@devongovett thanks for your input; what you wrote seems to work in Webpack, Rollup & Parcel! This may also be what @GeoffreyBooth meant by his last message that I misunderstood....

Side-note: I removed the `production` & `development` conditions from my above proposal. They are reported by Webpack & Parcel but not by Rollup. The way we added them initially doesn't...

The fix will be available in jQuery `4.0.0-beta.2` when that gets released.

Oh, interesting. Perhaps we should update this list for 4.0 as this can be considered a breaking change. Or we should get rid of this manual normalization, depending on users...

Tentatively adding it to `4.0.0` blockers so that we don't release before discussing this first.

I did a query on GitHub for calls like `".attr('disabled', false)"` - and the same for other attributes - to see their popularity. This is not ideal - it only...

@gibson042 > I am of the opinion that we should remove special treatment for any boolean attribute, generalizing the .attr(name, false) setter to remove any attribute (which is both convenient...

I thought about my original proposal and I think if we want to special-case, we should include more attributes, though, perhaps all with >50 search results above. Our unit tests...

I submitted #5451 implementing the conservative approach I mentioned above. We can make it less conservative be removing one or two parts from it. Let's discuss this today. We can...

At the meeting, we decided to: 1. Remove any special boolean attributes treatment 2. Make the `false` value trigger attribute removal for all non-ARIA attributes, stringify it to `"false"` for...