Michał Gołębiowski-Owczarek
Michał Gołębiowski-Owczarek
PR with a fix: #2144
We consider this a breaking change which is why it’s scheduled for 1.14.0. We don’t expect that version to arrive soon, though.
We should also remove the `build` & `.github` folders from the package, BTW.
Followup work extracted to #5468 per the last team meeting.
Thanks for the report. Since the issue is already in 1.12, given limited team resources it's not likely to be fixed by the UI team; see the project status at...
Currently `grunt-ng-annotate` combines source maps but AFAIK only if the input source map is inline in the generated file. This is mostly handled by [ng-annotate](https://github.com/olov/ng-annotate), though, I'm mostly just constructing...
@stefan-- Interesting; I have a test for combining source maps that ensures combining with Babel inline source maps works: https://github.com/mzgol/grunt-ng-annotate/blob/259f56efd9f51a32ac1e54ea50f640bcca0efc29/test/spec/api.js#L116-L138. Both the fact that `sources` point to the original file...
Hmm, OK, it seems a basic example with `grunt-contrib-concat` should reproduce the problem then. I'll see what I can do (once I find time, it's been busy for me recently)....
Could you write how you call it (with what parameters)? I'll check later what I do incorrectly here. For reference, this is where `ng-annotate` is called: https://github.com/mzgol/grunt-ng-annotate/blob/259f56efd9f51a32ac1e54ea50f640bcca0efc29/tasks/ng-annotate.js#L168
Ah, so it breaks not with inline source maps but with external ones? That's possible, I have a test for combining inline source maps but no test for combining external...