Martin Gencur
Martin Gencur
I suppose this problem can also occur when the LivenessProbe has a different PeriodSeconds or/and FailureThreshold from the ReadinessProbe. In this case, the Readiness probe might spot a failure at...
The test for liveness probe failure was inspired by https://github.com/knative/serving/pull/12497. The [issues](https://github.com/knative/serving/pull/12497#issuecomment-1056187972) that were blocking the original PR were either resolved (the main one) or I found a workaround (the...
This PR removes an invalid comment about container probes [here](https://github.com/knative/serving/pull/15180/files#diff-874e991d6178734f4fec8bb5d3823e1e1582d313e761c21c390a78c2aa91477cL444) Multi-container probes were added in https://github.com/knative/serving/pull/14853 @dsimansk @dprotaso Could any of you approve this change? Thanks
I will reopen this when the related knative/pkg PR is merged.
Rebased. Just to be sure this works after some time. @dprotaso Could you review this please? There's a commit which haven't been reviewed. See [comment](https://github.com/knative/pkg/pull/2591#discussion_r973972854)
@dprotaso Thank you!
I feel like this might already be covered by [SendsEventsWithEventTypes](https://github.com/knative/eventing/blob/main/test/rekt/features/apiserversource/data_plane.go#L275) which is called from [TestApiServerSourceDataPlane_SinkTypes](https://github.com/knative/eventing/blob/main/test/rekt/apiserversource_test.go#L69) We need to check why this test is passing even without enabling the auto-create feature.