eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Add rekt test for ApiServerSource event type autocreate

Open mgencur opened this issue 1 year ago • 3 comments

Problem Create a REKT test to the experimental folder that will verify automatic EventType creation for ApiServerSource.

Persona: Which persona is this feature for?

Exit Criteria E2E test which verifies that EventType is properly created when ApiServerSource is created. The EventType's spec.type should correspond to types of events defined in constants

Time Estimate (optional): How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)

Similar to Add rekt test for broker event type autocreate

mgencur avatar Jan 24 '24 12:01 mgencur

I feel like this might already be covered by SendsEventsWithEventTypes which is called from TestApiServerSourceDataPlane_SinkTypes We need to check why this test is passing even without enabling the auto-create feature.

mgencur avatar Jan 25 '24 10:01 mgencur

I think the test is passing because Sources are able to automatically create the EventType even without enabling the experimental auto-create feature.

mgencur avatar Jan 26 '24 10:01 mgencur

@mgencur yes, see here for a future plan https://github.com/knative/eventing/issues/7258#issuecomment-1907591397

pierDipi avatar Jan 26 '24 11:01 pierDipi

This is already covered. As mentioned in the comments.

mgencur avatar Apr 04 '24 08:04 mgencur