No test coverage for liveness probes

[julz]

Describe the feature

While we currently have tests for user-supplied readiness probes, we don't have much (~any :)) e2e/conformance coverage for user-supplied liveness probes. After https://github.com/knative/serving/pull/12479 knative should largely leave liveness probes alone (previously we routed them via QP, which caused problems in https://github.com/knative/serving/issues/12462), but we should nevertheless have some test coverage that user-supplied liveness probes work correctly.

/area API /kind good-first-issue

[knative-prow-robot]

@julz: The label(s) kind/good-first-issue cannot be applied, because the repository doesn't have them.

In response to this:

Describe the feature

While we currently have tests for user-supplied readiness probes, we don't have much (~any :)) e2e/conformance coverage for user-supplied liveness probes. After https://github.com/knative/serving/pull/12479 knative should largely leave liveness probes alone (previously we routed them via QP, which caused problems in https://github.com/knative/serving/issues/12462), but we should nevertheless have some test coverage that user-supplied liveness probes work correctly.

/area API /kind good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nader-ziada]

/assign

[Shashankft9]

hey @nader-ziada have you already started on this? if not (and also if this issue is not a priority), I would like to make an attempt towards this :)

[nader-ziada]

hey @nader-ziada have you already started on this? if not (and also if this issue is not a priority), I would like to make an attempt towards this :)

hey @Shashankft9 I briefly looked at it, but now working on a different PR, please go ahead and take it over if you would like

[nader-ziada]

/unassign

since @Shashankft9 is working on it

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

[Shashankft9]

/reopen /assign

[knative-prow[bot]]

@Shashankft9: Reopened this issue.

In response to this:

/reopen /assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

[psschwei]

/lifecycle frozen

[dprotaso]

/unassign @Shashankft9

[mgencur]

/assign