pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Allow logstream to stream logs from user namespace

Open mgencur opened this issue 2 years ago • 6 comments

  • When streaming logs from user namespace, disable filtering lines so all lines are printed.

More information on when this comes handy is available in Serving PR: https://github.com/knative/serving/pull/13293, together with usage example. It will be very handy also in knative/eventing upgrade tests where multiple pods are started and the Sender pod is removed before the test ends.

Changes

/kind

Fixes #

Release Note


Docs


mgencur avatar Sep 12 '22 09:09 mgencur

@mgencur: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

  • When streaming logs from user namespace, disable filtering lines so all lines are printed.

More information on when this comes handy is available in Serving PR: https://github.com/knative/serving/pull/13293, together with usage example. It will be very handy also in knative/eventing upgrade tests where multiple pods are started and the Sender pod is removed before the test ends.

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Sep 12 '22 09:09 knative-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval by writing /assign @upodroid in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Sep 12 '22 09:09 knative-prow[bot]

Codecov Report

Base: 81.35% // Head: 81.32% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (3d0c01f) compared to base (bd66b9b). Patch has no changes to coverable lines.

:exclamation: Current head 3d0c01f differs from pull request most recent head 77e8be9. Consider uploading reports for the commit 77e8be9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2591      +/-   ##
==========================================
- Coverage   81.35%   81.32%   -0.03%     
==========================================
  Files         162      162              
  Lines        9841     9820      -21     
==========================================
- Hits         8006     7986      -20     
- Misses       1594     1595       +1     
+ Partials      241      239       -2     
Impacted Files Coverage Δ
metrics/config.go 75.55% <0.00%> (-8.48%) :arrow_down:
...k/resourcesemantics/validation/validation_admit.go 93.12% <0.00%> (-0.26%) :arrow_down:
webhook/webhook.go 74.80% <0.00%> (-0.20%) :arrow_down:
apis/field_error.go 95.58% <0.00%> (-0.04%) :arrow_down:
webhook/helper.go 100.00% <0.00%> (ø)
changeset/commit.go 100.00% <0.00%> (ø)
profiling/server.go 76.00% <0.00%> (ø)
depcheck/depcheck.go 83.33% <0.00%> (ø)
tracing/opencensus.go 48.11% <0.00%> (ø)
injection/injection.go 0.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 12 '22 09:09 codecov[bot]

/retest

mgencur avatar Sep 12 '22 09:09 mgencur

The test failures look unrelated.

mgencur avatar Sep 12 '22 10:09 mgencur

/retest

mgencur avatar Sep 19 '22 09:09 mgencur

Rebased. Just to be sure this works after some time.

@dprotaso Could you review this please? There's a commit which haven't been reviewed. See comment

mgencur avatar Nov 22 '22 11:11 mgencur

/retest /lgtm /approve

dprotaso avatar Jan 04 '23 19:01 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jan 04 '23 19:01 knative-prow[bot]

@dprotaso Thank you!

mgencur avatar Jan 04 '23 20:01 mgencur