pkg
pkg copied to clipboard
Allow logstream to stream logs from user namespace
- When streaming logs from user namespace, disable filtering lines so all lines are printed.
More information on when this comes handy is available in Serving PR: https://github.com/knative/serving/pull/13293, together with usage example. It will be very handy also in knative/eventing upgrade tests where multiple pods are started and the Sender pod is removed before the test ends.
Changes
/kind
Fixes #
Release Note
Docs
@mgencur: The label(s) kind/<kind>
cannot be applied, because the repository doesn't have them.
In response to this:
- When streaming logs from user namespace, disable filtering lines so all lines are printed.
More information on when this comes handy is available in Serving PR: https://github.com/knative/serving/pull/13293, together with usage example. It will be very handy also in knative/eventing upgrade tests where multiple pods are started and the Sender pod is removed before the test ends.
Changes
/kind
Fixes #
Release Note
Docs
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval by writing /assign @upodroid
in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Base: 81.35% // Head: 81.32% // Decreases project coverage by -0.02%
:warning:
Coverage data is based on head (
3d0c01f
) compared to base (bd66b9b
). Patch has no changes to coverable lines.
:exclamation: Current head 3d0c01f differs from pull request most recent head 77e8be9. Consider uploading reports for the commit 77e8be9 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #2591 +/- ##
==========================================
- Coverage 81.35% 81.32% -0.03%
==========================================
Files 162 162
Lines 9841 9820 -21
==========================================
- Hits 8006 7986 -20
- Misses 1594 1595 +1
+ Partials 241 239 -2
Impacted Files | Coverage Δ | |
---|---|---|
metrics/config.go | 75.55% <0.00%> (-8.48%) |
:arrow_down: |
...k/resourcesemantics/validation/validation_admit.go | 93.12% <0.00%> (-0.26%) |
:arrow_down: |
webhook/webhook.go | 74.80% <0.00%> (-0.20%) |
:arrow_down: |
apis/field_error.go | 95.58% <0.00%> (-0.04%) |
:arrow_down: |
webhook/helper.go | 100.00% <0.00%> (ø) |
|
changeset/commit.go | 100.00% <0.00%> (ø) |
|
profiling/server.go | 76.00% <0.00%> (ø) |
|
depcheck/depcheck.go | 83.33% <0.00%> (ø) |
|
tracing/opencensus.go | 48.11% <0.00%> (ø) |
|
injection/injection.go | 0.00% <0.00%> (ø) |
|
... and 6 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
/retest
The test failures look unrelated.
/retest
Rebased. Just to be sure this works after some time.
@dprotaso Could you review this please? There's a commit which haven't been reviewed. See comment
/retest /lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dprotaso, mgencur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~test/OWNERS~~ [dprotaso]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@dprotaso Thank you!