Martin Geisler

Results 861 comments of Martin Geisler

Hi @shinmili, thank you so much for putting this up! I think this looks good and I left some minor comments.

> I don't know that I care to deal with a CLA for such a small change. I welcome anyone else to recreate this, which should be trivial even without...

#267 should do the same, thanks again!

> I am not sure if mdbook has support for this upstream, but ideally the book title and description should also be translated. Currently they are not. Yes, that would...

I'm not 100% sure, though, that it's possible for a `renderer` to overwrite this. It will have to be tested out for us to be sure.

@gribozavr, can you add the "good first issue" label here? (Or give me access again 😅).

> I'm not 100% sure, though, that it's possible for a `renderer` to overwrite this. It will have to be tested out for us to be sure. My understanding now...

Hi @hwhsu1231, thanks a lot for the report! We will definitely want to make the extension compatible with the latest version of `mdbook`! The links in https://github.com/rust-lang/mdBook/issues/2835 to the commits...

I'm seeing this too... Looking at a recent CI log, I see that we're using [`gettext` version 0.21-4ubuntu4](https://launchpad.net/ubuntu/+source/gettext/+changelog#:~:text=gettext%20(0.21%2D4ubuntu4)) on the GitHub runners. The changelog shows lots of packaging changes between...