Martin Geisler

Results 872 comments of Martin Geisler

Very small point: I renamed the PR title to `ar: ...` — this simply serves to give the resulting commit a uniform look.

> * Make `mdbook-xgettext` optional with `optional: true` in `book.toml`. Make it exit early when it sees that it's optional. If this works well, we could use it for the...

> * It'd be nice to come up with a scheme that could accomplish both. I think interpreting `optional` as "don't break the build" and using `run-if-optional` to prevent running...

> Bikeshed: how about `skip-if-optional = true` instead of `run-if-optional = false`? I'm happy with `skip-if-optional`!

> > Thinking about this some more, it feels odd to have `optional` and `skip-if-optional` (logically, `A` and `A => B`) instead of `optional` and another option that disables the...

> Unfortunately this causes problems for mozilla-central, so we need to hold off on this for at least the next release. Ah, thanks for looking! I tried to read rust-versions.md...

Thanks both for explaining! So it seems we're in the same boat :sweat_smile: Just with different trees of crates to update. On my side in Android, I'll just carry the...

> We pull in other trusted audits from Google (via https://github.com/google/rust-crate-audits). > Would you be able to do those audits? That would speed things along. Yes, I like to help...

I looked a bit at the `cargo vet` reviews today, but didn't immediately find a place for me to put them so that they end up in https://github.com/google/rust-crate-audits. I'll have...