Martin Geisler

Results 865 comments of Martin Geisler

Okay, it sounds like we're on the same page then with regards to an overall API. My main priority right now is to get the current rewrite released, so I'm...

> Coincidentally, I have combined `textwrap` and `pulldown_cmark` in a library called [`runwrap`](https://github.com/veikman/runwrap). It has some known limitations (see the readme) and does not handle subsequent indentation nicely in indented...

Hey Ian, thanks a lot, I'm glad you got it working :smile: I've only had a quick look and I agree with you that it looks a bit strange that...

> `wrap`, `wrap_columns`, and `fill_inplace` all have tests, though, and should work just as expected. Perhaps I'm blind, but I don't see new tests for `wrap`? I think it would...

> There are some functions in the library that I couldn't find a way to add support for tab widths within (specifically, `unfill`, since you have no way to pass...

I tried running the wrapping benchmark on your branch, and it now takes ~20% longer to wrap the text: ``` % cargo criterion fill_optimal_fit_ascii/4800 String lengths/fill_optimal_fit_ascii/4800 time: [257.09 us 260.30...

> I saw what you said about not including a `tab_width` parameter on `Word`, but instead calculating the whitespace width on the word after it's already been created, and I...

Hi Ian, > but then we would need to keep `tab_width` as a parameter of `Word` for circumstances when a tab is contained in the word You mean because we...

Hey @mtoohey31, I think it would be great if you would jump in and work on this! Looking over https://github.com/helix-editor/helix/issues/3622, I think a first step would be to let `unfill`...

> And thanks @mgeisler, I'll start with `unfill` as you've suggested. I would like to allow tab width to be configured too, but as you say it looks like that'll...