Martin Geisler

Results 861 comments of Martin Geisler

> I don't think we would have to modify the input string at all for what I'm suggesting, just calculate its width based on the assumption that a tab will...

Hey @edio, thanks for opening the issue. Super exciting that textwrap is used in the editor! You're not missing anything, textwrap is hard-coded to split on `\n` in [`textwrap::wrap`](https://github.com/mgeisler/textwrap/blob/6fa2cd848a6611e10f74ec9ff0a89c8b1bc7ce80/src/lib.rs#L918). I...

Another thing: I think Helix is the first place which uses `textwrap::refill` for real. So if you run into problems with it, then please let me know. Most of the...

> Works better for the client, but introduces a slight behavoir inconsistency for this lib: it handles any line ending in the input, but only outputs `\n`. Not sure if...

> @mgeisler , I benchmarked `wrap` with `lines()` vs `split('\n')` on 4800 input, and consistently across multiple runs the `lines()` version is slower. `lines()` additionally removes `\r` in the end...

Hi @lunaryorn, I'm not 100% sure what you're trying to do, but are you perhaps translating the events into console text? With bold and underlined text via ANSI escape codes?...

Ah, thank you for the example — that was super helpful! I've rewritten the wrapping algorithm recently (#221) and I am wondering how the new system can be adapted to...

One question, though: with such an API, you won't be able to tell where each piece of text ends in the wrapped lines. That is, if you call `add_text` three...

> For my purposes the amount of control "initial_indent" and "subsequent_indent" give me should be sufficient. How do you intend to use those parameters? I'm imagining that they're fixed from...