Michael Ganss comments

Results 275 comments of


                                            Michael Ganss

Return a converted date from UTC to local

Can you elaborate a little? What is the `DateTimeKind` of the `DateTime` values you're exporting and what kind of value do you expect in the exported Excel file?

Return a converted date from UTC to local

I think before exporting you need to map the DateTime values to local time using `ToLocalTime()`.

refactor a parameter for SetCellUsing and SetPropertyUsing

Thanks. There are some uncovered lines still, though.

refactor a parameter for SetCellUsing and SetPropertyUsing

> I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete. Can you add this to the PR?

'NPoco.PocoExpando' does not contain a definition for 'TableName'

Strange. Can you set a breakpoint inside the GroupBy to see what the contents of the dynamic object look like?

'NPoco.PocoExpando' does not contain a definition for 'TableName'

What happens if you step further? Which properties do the dynamic objects have? You can set breakpoints inside lambdas by placing the cursor in the lambda function, right click and...

CSS styles stripping rgb when capitalized

This has been fixed in AngleSharp.Css 0.17.0.

Some property values are removed when sanitized

Resolved in AngleSharp.Css 0.17.0 and thus HtmlSanitizer 8.0.638.

Margin as CSS property strips unnecessary values

This has been fixed in AngleSharp.Css 0.17.0.

Don't Pin AngleSharp Version

@FlorianRappl Is the AngleSharp API sufficiently stable now so that we wouldn't run the risk of encountering issues like those mentioned above in https://github.com/mganss/HtmlSanitizer/issues/87#issuecomment-246499156 if we no longer pinned the...