ExcelMapper icon indicating copy to clipboard operation
ExcelMapper copied to clipboard

refactor a parameter for SetCellUsing and SetPropertyUsing

Open andywu188 opened this issue 3 years ago • 6 comments

  1. Solve the problem that SetCellUsing and SetPropertyUsing parameters are not named and ambiguous.
  2. Improved support for parameters that can perform multiple property value calculations

andywu188 avatar Aug 26 '22 07:08 andywu188

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.27%. Comparing base (1ecae95) to head (3225253).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   94.29%   95.27%   +0.97%     
==========================================
  Files          11       13       +2     
  Lines        1384     1417      +33     
  Branches      203      203              
==========================================
+ Hits         1305     1350      +45     
+ Misses         51       39      -12     
  Partials       28       28              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 26 '22 07:08 codecov[bot]

Thanks. There are some uncovered lines still, though.

mganss avatar Aug 26 '22 10:08 mganss

already updated

andywu188 avatar Aug 26 '22 11:08 andywu188

I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete.

andywu188 avatar Aug 26 '22 11:08 andywu188

I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete.

Can you add this to the PR?

mganss avatar Aug 26 '22 13:08 mganss

already updated

andywu188 avatar Sep 26 '22 03:09 andywu188